Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inject content hash into document preview URL #1342

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

vsgoulart
Copy link
Contributor

This PR adds the content hash injection into the document preview URL so it works with Camunda Tasklist.
This is a temporary fix and we should try to remove it as soon as we can for the reasons explained here: #1341

Closes #1340

  • This PR adds a new form-js element or visually changes an existing component.

@vsgoulart vsgoulart requested a review from Skaiir December 19, 2024 12:54
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 19, 2024
@Skaiir
Copy link
Contributor

Skaiir commented Dec 19, 2024

Due to time constraints, it makes sense to approve this as-is, but the solution long term should involve creating an extension point via modules for the consuming library to override.

@vsgoulart vsgoulart changed the base branch from develop to main December 19, 2024 16:29
@vsgoulart vsgoulart merged commit 4e9b7da into main Dec 19, 2024
12 of 13 checks passed
@vsgoulart vsgoulart deleted the 1340-inject-cotent-hash branch December 19, 2024 16:29
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject content hash into URL into document preview URL
2 participants